Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo_conda: is the subdir handling correct? #502

Open
mlschroe opened this issue Jul 1, 2022 · 2 comments
Open

repo_conda: is the subdir handling correct? #502

mlschroe opened this issue Jul 1, 2022 · 2 comments
Assignees

Comments

@mlschroe
Copy link
Member

mlschroe commented Jul 1, 2022

It seems like a subdir element in the individual package repodata is always overwritten with current conda versions.
The conda upstream commit that changed this seems to be: conda/conda@6d1a517

So, should we drop adding the subdir to the location elements? Or should we add a repo_add_conda_subdir() method that also takes a subdir if there is no subdir in the info element?

@mlschroe mlschroe self-assigned this Jul 1, 2022
@mlschroe
Copy link
Member Author

mlschroe commented Jul 1, 2022

@wolfv please help

@wolfv
Copy link
Contributor

wolfv commented Jul 1, 2022

I think you're right, if there is a subdir specified in an individual package record it will get overwritten by the "global" subdir.

Not sure if it matters much since they should be equal anyways (if both are present).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants