Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-update of versions: failures should be reported. #5762

Open
chalin opened this issue Dec 11, 2024 · 0 comments
Open

Auto-update of versions: failures should be reported. #5762

chalin opened this issue Dec 11, 2024 · 0 comments
Assignees
Labels
CI/infra CI & infrastructure p1-high

Comments

@chalin
Copy link
Contributor

chalin commented Dec 11, 2024

This issue offers some analysis of the failures that lead to a fix being proposed in the following PR:

After some investigation, here is what I've found:

(1) On Nov 13, 2024, 1:17 AM EST, the Auto-update versions #15240 job failed: https://github.com/open-telemetry/opentelemetry.io/actions/runs/11811741891/job/32905820377.

It failed, as @zeitlinger reports in #5758, because two runs of the subscript are attempting to create a PR for a single repo. The first subscript is successful, but the second fails because "a PR already exists" for the given repo version update.

I can't recall if maintainers get any notice about such failures? If not, maybe the script(s) should be altered so create an issue? Or we should have a process to monitor the GH actions and report any failures? Maybe @zeitlinger's proposal to have only one run per repo is the simplest solution.

(2) The next scheduled run at Nov 13, 2024, 2:16 AM EST of the script Auto-update versions #15241 passed because it saw that a PR had already been created and assumed that all was wel.

I think that we have an opportunity to improve things here. If there are changes pending, and a PR exists but has been merged, a new PR should be created. This would allow us to catch partial updates.


There is a separate problem that #5758 has surfaced, because it's build is currently failing, see https://github.com/open-telemetry/opentelemetry.io/actions/runs/12278556636/job/34260597540?pr=5758. For details, see:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure p1-high
Projects
Status: No status
Development

No branches or pull requests

1 participant