Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebar3_eqwalizer was removed and CI is broken. #810

Open
ferd opened this issue Dec 20, 2024 · 3 comments
Open

rebar3_eqwalizer was removed and CI is broken. #810

ferd opened this issue Dec 20, 2024 · 3 comments

Comments

@ferd
Copy link
Member

ferd commented Dec 20, 2024

The changeset, as of WhatsApp/eqwalizer@786f0da removes the rebar3 plugin.

It seemingly now requires ELP to be installed and running and to use a distinct plugin to work.

Since we were pulling from main on the plugin, all CI for these libs are now broken.

Do we want to try and fix this or do we just rip it out to get going faster at this point?

@ferd ferd changed the title rebar3_ewqalizer was removed and CI is broken. rebar3_eqwalizer was removed and CI is broken. Dec 20, 2024
@bryannaegele
Copy link
Contributor

I vote for fastest fix. It's been a "nice to have" but hasn't proven critical.

@tsloughter
Copy link
Member

it is critical. but the plugin isn't needed, I haven't used it in ages in other projects and just forgot to do the removal here.

@tsloughter
Copy link
Member

To be clear, I'll try to clean this up today. So PRs to come.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants