-
-
Notifications
You must be signed in to change notification settings - Fork 150
Bug: Footer not stay at the bottom #417
Comments
Good exercise in sticky footers: https://css-tricks.com/couple-takes-sticky-footer/ |
I can |
Seems like the issue has been solved, I could not reproduce it. |
Can you please provide your steps? Because I opened in hot, and reproduced this issue |
I opened it from the browser directly: https://hot.opensauced.pizza/ |
Still an issue? |
Yes, the footer still has this issue. |
Okay ! Here's what I understood from the issue and web page . |
Yes, this is what we need. |
@NsdHSO Is the footer in the video acting as you want ? If yes, please let me know and I'll create a pull request. Thanks! |
@VinceCYLiao sorry I can't open this video |
@NsdHSO Sorry I should convert the video into gif. Please check, thanks. |
@NsdHSO Correct me if I'm wrong but I think its because the list of repositories renders after few seconds (waiting for server's data) and there is no loading component to render in the time the component is fetching the data from server so I added the loader and made a PR if it helps. |
@westernal Yes, this is what we want, Tnx for your PR, but can you please check this little doc |
Describe the bug
Steps to reproduce
Affected services
hot.opensauced.pizza
Platforms
Desktop
Browsers
Chrome
Environment
Production
Additional context
No response
Code of Conduct
Contributing Docs
The text was updated successfully, but these errors were encountered: