-
-
Notifications
You must be signed in to change notification settings - Fork 147
Feature: submit new repo with shortcut #415
Comments
I saw that we have |
For the moment in this component we don't use headlessui combobox we use native input. I think if you want can you open a new issue, to see what the other colleagues say |
We do, we can also leverage radix components
It does not make sense to complicate the current solution with keyboard accessibility when the baseline itself is not very accessible. I would agree the keyboard shortcut would be nice to have on top of an already accessible dropdown menu that displays some more information while typing and potential errors inline. IMHO the UI components we have installed already could take care of a11y and enable this issue to be done, but it should at least mention improving the baseline! 🍕 |
Oh, didn't know about radix, it looks great 💯
Yeah using radix react dropdown will fix this issue 🍕 |
How can I contribute to this? |
Do you have any suggestions or approach based on the existing conversation? |
Type of feature
🍕 Feature
Current behavior
If you want to submit a new repository for suggestions, you can't use shortcuts like cmd+enter/enter or escape to close the popup window
Suggested solution
Here is an example
hot/src/components/Hero.tsx
Lines 17 to 44 in ecebb1e
Additional context
No response
Code of Conduct
Contributing Docs
The text was updated successfully, but these errors were encountered: