Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: a11y rule "iframe-has-title" fails with a warning. #4134

Closed
Tracked by #4139
FatumaA opened this issue Sep 26, 2024 · 4 comments · Fixed by #4162
Closed
Tracked by #4139

enhancement: a11y rule "iframe-has-title" fails with a warning. #4134

FatumaA opened this issue Sep 26, 2024 · 4 comments · Fixed by #4162
Assignees
@Bashamega
Labels
a11y Issues related to accessibility 🐛 bug Something isn't working hacktoberfest Issues for https://hacktoberfest.digitalocean.com/ released on @beta released

Comments

@FatumaA
Copy link
Contributor

FatumaA commented Sep 26, 2024

Describe the bug

jsx-a11y eslint plugin was recently added to the project and this rule - jsx-a11y/iframe-has-title - fails with a warning.

This issue offers more context: #2264

Steps to reproduce

The following components and files are causing the rule to fail:

  1. pages/u/[username]/card.tsx
@FatumaA FatumaA added 🐛 bug Something isn't working 👀 needs triage labels Sep 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please comment on this issue.

For full info on how to contribute, please check out our contributors guide.

@nickytonline nickytonline mentioned this issue Sep 26, 2024
Open
14 tasks
@nickytonline nickytonline added hacktoberfest Issues for https://hacktoberfest.digitalocean.com/ a11y Issues related to accessibility labels Oct 1, 2024
@Bashamega
Copy link
Contributor

.take

Bashamega added a commit to Bashamega/app that referenced this issue Oct 12, 2024
@Bashamega
fix(.\pages\u\[username]\card.tsx): fix: a11y rule "iframe-has-title"…
66936fe 
… fails with a warning

fixed by adding a title to the iframe

fix open-sauced#4134
@Bashamega Bashamega mentioned this issue Oct 12, 2024
Merged
4 tasks
@open-sauced Open Sauced
Copy link
Contributor

open-sauced bot commented Oct 15, 2024

🎉 This issue has been resolved in version 2.64.0-beta.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@open-sauced Open Sauced
Copy link
Contributor

open-sauced bot commented Oct 22, 2024

🎉 This issue has been resolved in version 2.64.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@open-sauced open-sauced bot added the released label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bashamega Bashamega

Labels
a11y Issues related to accessibility 🐛 bug Something isn't working hacktoberfest Issues for https://hacktoberfest.digitalocean.com/ released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: a11y rule "iframe-has-title" fails with a warning. Bashamega/app
3 participants
@nickytonline @FatumaA @Bashamega