Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZFA/Uberon issues: simple errors in Uberon #3354

Open
gouttegd opened this issue Sep 4, 2024 · 0 comments
Open

ZFA/Uberon issues: simple errors in Uberon #3354

gouttegd opened this issue Sep 4, 2024 · 0 comments
Assignees
Labels

Comments

@gouttegd
Copy link
Collaborator

gouttegd commented Sep 4, 2024

A few of the root unsatisfiable classes found in the merge product of Uberon and ZFA are caused by what I believe are simple errors that are entirely internal to Uberon (and that are merely revealed by the merge with ZFA).

uvea

uvea is said to be part_of the 'anterior segment of eyeball', which is defined as “any of the parts of the eye that lie in front of, or ventral to, the lens (inclusive)”.

That doesn’t sound correct as, from what I can see, the uvea clearly appears to extend dorsally relative to the lens (if only by its 'optic choroid' part, which is incidentally said to overlap the 'posterior segment of eyeball.

The uvea part_of some 'anterior segment of eyeball' axiom should be removed – possibly replaced by a relationship to a larger structure, though this may not be needed since there is already axiom stating that uvea 'contributes to the morphology of' some 'camera-type eye', which should be enough.

'future brain vesicle'

'future brain vesicle' (no text definition) is classified as an 'open anatomical space', ultimately an immaterial anatomical entity.

That does not seem consistent with Uberon’s “habits” of representing most anatomical cavities or spaces with terms representing the (material) structures that make them (plus optionally terms to represent the actual space inside, if it is needed for some reason).

'future brain vesicle' is part_of the 'ventricular system of central nervous system', which is explicitly defined as “a set of structures containing cerebrospinal fluid in the brain” (emphasis mine).

I believe the brain vesicles should be made to be material anatomical structures rather than immaterial anatomical spaces. If needed, we could create a new term “lumen of brain vesicle” to refer to the actual space within those vesicles, similarly to 'lumen of central canal of spinal cord'.

'scale circulus'

'scale circulus' is classified as an immaterial 'anatomical line', contrary to its ZFA counterpart which is a material 'anatomical structure'.

The text definition says it is a “fine ridge on surface of scale”, which suggests to me that ZFA is right in making it a material structure. If it is a “ridge”, then it must have some consistence.

@gouttegd gouttegd self-assigned this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant