Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netlify PR reviews are not working #560

Open
tobiasdiez opened this issue Apr 23, 2024 · 3 comments
Open

Netlify PR reviews are not working #560

tobiasdiez opened this issue Apr 23, 2024 · 3 comments
Assignees
Labels
type: chore Helpful for the development of this module

Comments

@tobiasdiez
Copy link
Collaborator

The PR previews are not published and are "pending review" under https://app.netlify.com/sites/nuxt-storybook/deploys.

Not sure why and I don't have access to the netlify config to investigate further.

@tobiasdiez tobiasdiez added the type: chore Helpful for the development of this module label Apr 25, 2024
@tobiasdiez
Copy link
Collaborator Author

@chakAs3 could you please have a look? It only happens for PR from people; the ones from renovate are correctly published.

@chakAs3
Copy link
Collaborator

chakAs3 commented Aug 17, 2024

@tobiasdiez I’ve approved the last one from you. Can you please check if everything is good?

@tobiasdiez
Copy link
Collaborator Author

Thanks, that worked for this particular deployment. However, new ones are still pending review, eg #762 (comment).

Maybe enabling https://docs.netlify.com/site-deploys/overview/#enable-auto-approval-for-deploy-requests or disabling https://docs.netlify.com/site-deploys/overview/#require-manual-review-for-deploy-requests works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore Helpful for the development of this module
Projects
None yet
Development

No branches or pull requests

2 participants