Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent integration of libraries #156

Open
sp1tz opened this issue Mar 4, 2020 · 0 comments
Open

Consistent integration of libraries #156

sp1tz opened this issue Mar 4, 2020 · 0 comments

Comments

@sp1tz
Copy link
Contributor

sp1tz commented Mar 4, 2020

Currently, the entire 220 library of functions is exposed as a global lib220. However, this is not the case for other libraries where we define separate globals for each of the methods. This scheme presents a tighter coupling between EJS and its libraries, which makes it harder to update them. Also, it unnecessarily pollutes the EJS global namespace.

Ideally, there would be no preset list of globals pertaining the libraries, which would force users to require every EJS library they wanted to utilize. At a minimum for now, we should expose each library as we do for 220, as a standalone single global object reference. This will also necessitate updates to the 220 assignments.

See /src/index.ts for context.

@sp1tz sp1tz changed the title Consistent Integration of Libraries Consistent integration of libraries Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants