Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create projects under additional VS versions #4

Open
CharliePoole opened this issue Dec 21, 2017 · 2 comments
Open

Create projects under additional VS versions #4

CharliePoole opened this issue Dec 21, 2017 · 2 comments

Comments

@CharliePoole
Copy link
Contributor

I was thinking VS2012 and VS2013. @OsirisTerje What do you think?

@OsirisTerje
Copy link
Member

OsirisTerje commented Dec 23, 2017

Do we need separate projects for these versions? They use the same project format. But, in VS2017 we can can use either the new or the old project format, and the new one is different from the old, so perhaps we should add that? But then, it would use the same C# files, only they should stay in the same folder structure.
As it is now, the files are linked in, and that doesn't really go well with the standard in the new format, although it works with the links, it is not standard.

@CharliePoole
Copy link
Contributor Author

Is project format the only thing that can go wrong between versions? I'm thinking, for example, of errors that get introduced if the adapter references something that isn't in the older versions of vs.

We may not need more than one project, but if we say we work under VSxxxx, then doesn't it seem we need to test that?

OsirisTerje added a commit that referenced this issue Feb 18, 2018
Updated tests and project to work  #4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants