Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN issues #14

Closed
mattfidler opened this issue Nov 27, 2023 · 2 comments · Fixed by #15
Closed

CRAN issues #14

mattfidler opened this issue Nov 27, 2023 · 2 comments · Fixed by #15

Comments

@mattfidler
Copy link
Member

Dear maintainer,

Please see the problems shown on
https://cran.r-project.org/web/checks/check_results_dparser.html.

Please correct before 2023-12-11 to safely retain your package on CRAN.

Best,
-k

@mattfidler
Copy link
Member Author

  Found the following significant warnings:
    gram.c:689:22: warning: ‘%s’ directive argument is null [-Wformat-overflow=]
    gram.c:1450:14: warning: ‘%s’ directive argument is null [-Wformat-overflow=]
    gram.c:1447:21: warning: ‘%s’ directive argument is null [-Wformat-overflow=]
  util.c:88:9: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
  util.c:99:11: warning: format string is not a string literal (potentially insecure) [-Wformat-security]

@mattfidler
Copy link
Member Author

Result: NOTE 
  checkRd: (-1) dparser-package.Rd:159-281: Lost braces
     159 | \itemize{\item  Terminal modifiers}{
         |                                    ^
  checkRd: (-1) dparser-package.Rd:172: Lost braces; missing escapes or markup?
     172 | It is now possible to use $0.symbol == ${string parameter_comma} to differentiate ParseNode ($0) between
         |                                         ^
  checkRd: (-1) dparser-package.Rd:277: Lost braces; missing escapes or markup?
     277 | ${declare longest_match ...}.  If global longest match
         |  ^
  checkRd: (-1) dparser-package.Rd:278-279: Lost braces
     278 | disambiguation is \bold{ON}, it can be locally disabled with {$declare
         |                                                              ^
  checkRd: (-1) mkdparse.Rd:202-324: Lost braces
     202 | \itemize{\item  Terminal modifiers}{
         |                                    ^
  checkRd: (-1) mkdparse.Rd:215: Lost braces; missing escapes or markup?
     215 | It is now possible to use $0.symbol == ${string parameter_comma} to differentiate ParseNode ($0) between
         |                                         ^
  checkRd: (-1) mkdparse.Rd:320: Lost braces; missing escapes or markup?
     320 | ${declare longest_match ...}.  If global longest match
         |  ^
  checkRd: (-1) mkdparse.Rd:321-322: Lost braces
     321 | disambiguation is \bold{ON}, it can be locally disabled with {$declare
         |                                                              ^
Flavors: [r-devel-linux-x86_64-debian-clang](https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-debian-clang/dparser-00check.html), [r-devel-linux-x86_64-debian-gcc](https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-debian-gcc/dparser-00check.html)

Version: 1.3.1-10
Check: Rd \usage sections
Result: NOTE 
  Documented arguments not in \usage in Rd file 'show-dparserFunction-method.Rd':
    ‘x’
  
  Functions with \usage entries need to have the appropriate \alias
  entries, and all their arguments documented.
  The \usage entries must correspond to syntactically valid R code.
  See chapter ‘Writing R documentation files’ in the ‘Writing R
  Extensions’ manual.

@mattfidler mattfidler linked a pull request Nov 27, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant