Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enum aliases not supported #127

Open
rodaine opened this issue May 21, 2020 · 3 comments
Open

Enum aliases not supported #127

rodaine opened this issue May 21, 2020 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@rodaine
Copy link

rodaine commented May 21, 2020

Using protolock v0.15.0, with the following proto:

syntax="proto3";

enum Foo {
  BAR = 0;
  BAZ = 1;
}

After committing the lockfile, and making the following (backwards compatible) changes:

syntax="proto3";

enum Foo {
  option allow_alias = true;
  BAR = 0;
  BAZ = 1;
  QUUX = 1;
}

Running protolock status, we get the following error:

→ protolock status
CONFLICT: "Foo" field: "QUUX" integer: 1 has an updated name, previously "BAZ" [foo.proto]
@rodaine
Copy link
Author

rodaine commented May 21, 2020

For details on enum aliasing: https://developers.google.com/protocol-buffers/docs/proto3#enum

@nilslice
Copy link
Owner

thanks for reporting, I will take a look asap. turns out I configured github to stop notifying me for all repos? oops.

@nilslice nilslice added the help wanted Extra attention is needed label Aug 3, 2020
@nilslice
Copy link
Owner

nilslice commented Aug 3, 2020

quick update -- I haven't had a chance to really dig in here.. if anyone else feels like they want to give it a shot, please do!

adding the help wanted label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants