Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin wiki readme json missing fields #116

Open
wadejensen opened this issue Jul 31, 2019 · 2 comments
Open

Plugin wiki readme json missing fields #116

wadejensen opened this issue Jul 31, 2019 · 2 comments

Comments

@wadejensen
Copy link

I'm writing a Scala plugin to implement a compatibility check. For some reason I wrote the structure of the plugin input from the wiki readme rather than the code. In the process of getting it working I found some differences between the JSON structure in the readme and what is sent by protolock.

It seems I can't fork the wiki, so I'll attach a patch to this issue (apparently as a text file because Github won't accept a .patch file type...)
0001-update-readme-with-missing-fields.txt

PS: Thanks for writing protolock! It's a really elegant tool.

@nilslice
Copy link
Owner

nilslice commented Aug 1, 2019

@wadejensen - thanks a lot for pointing this out! I will make the edit you've suggested. I'd be interested to see your Scala plugin if you're able to share!

@wadejensen
Copy link
Author

Its pretty rudimentary, but more than happy to share when I get a chance to clean out any work specific stuff, @nilslice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants