Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated usage of notification notifier #966

Open
ChristophWurst opened this issue Jul 31, 2024 · 1 comment
Open

Deprecated usage of notification notifier #966

ChristophWurst opened this issue Jul 31, 2024 · 1 comment

Comments

@ChristophWurst
Copy link
Member

{
  "reqId": "zmocK7Zhtu3bDXD82WyI",
  "level": 0,
  "time": "2024-07-31T08:16:42+00:00",
  "remoteAddr": "127.0.0.1",
  "user": "admin",
  "app": "no app in context",
  "method": "GET",
  "url": "/ocs/v2.php/apps/notifications/api/v2/notifications",
  "message": "OCA\\TermsOfService\\Notifications\\Notifier::prepare() threw \\InvalidArgumentException which is deprecated. Throw \\OCP\\Notification\\UnknownNotificationException when the notification is not known to your notifier and otherwise handle all \\InvalidArgumentException yourself.",
  "userAgent": "Mozilla/5.0 (X11; Linux x86_64; rv:126.0) Gecko/20100101 Firefox/126.0",
  "version": "30.0.0.3",
  "data": []
}
@max-nextcloud
Copy link
Contributor

The \\OCP\\Notification\\UnknownNotificationException is available since Nextcloud 30. This debug message will turn into a warning with Nextcloud 33 and an Error with Nextcloud 39.

We currently create one release for 28 to 30 - so we'd need to check for the existance of UnkownNotificationException. I guess best to replace this when we are releasing for 30 to 32.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants