Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get rid of old ContactsActivity #4179

Open
mahibi opened this issue Sep 10, 2024 · 0 comments
Open

get rid of old ContactsActivity #4179

mahibi opened this issue Sep 10, 2024 · 0 comments
Labels
1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) enhancement New feature or request
Milestone
20.1.0

Comments

@mahibi
Copy link
Collaborator

mahibi commented Sep 10, 2024

It seems that the old ContactsActivity is still exisiting next to ContactsActivityCompose.
It's in use in ConversationInfoActivity to add more participants.

  • ContactsActivity should either be deleted and replaced by ContactsActivityCompose which must be able to handle the use case.
    or
  • code that is not used anymore in ContactsActivity should be deleted and the class should be renamed.

After all, ContactsActivityCompose should be renamed to ContactsActivity.

Nothing for 20.0.0, it should be done afterwards..
@mahibi mahibi added enhancement New feature or request 1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) labels Sep 10, 2024
@mahibi mahibi added this to the 20.1.0 milestone Sep 10, 2024
@mahibi mahibi modified the milestones: 20.1.0, 20.0.1, 20.0.2 Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) enhancement New feature or request
Projects
None yet
Milestone
20.1.0
Development

No branches or pull requests
2 participants
@mahibi @sowjanyakch