Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use higher-resolution favicons #633

Open
David-Development opened this issue Feb 5, 2020 · 3 comments
Open

Use higher-resolution favicons #633

David-Development opened this issue Feb 5, 2020 · 3 comments
Labels
API Impact API/Backend code enhancement help wanted

Comments

@David-Development
Copy link
Member

David-Development commented Feb 5, 2020

Is your feature request related to a problem? Please describe.
In the nextcloud news app for android I'm currently facing the issue that I would like to show the favicon in several places. In some places the favicon will be shown with at least 100x100px. However by nature favicons have a size of only 16x16px. Therefore the icon appears to be blurry. Due to recent developments in web development larger favicons are more common now.

Describe the solution you'd like
Since modern websites usually ship also higher resolutions of those favicons it would be nice if the favicons url for a given feed would already match those high-res icons. Otherwise all client apps need to download the website and extract the high-res link by themself.
I was trying to read through the code but I'm not sure if you update existing favicons regularly or if you only extract the link once while adding the feed. Also I wasn't able to find the code where the favicon factory is coming from. Or is it an external dependency?

For reference on how to extract high-res favicons: https://stackoverflow.com/a/22007642

Describe alternatives you've considered
As I already mentioned, if we stick to the current implementation I'd have to implement it in the android app. Due to the fact that I need to make an additional network call to the website I'd rather do it here where the favicon is extracted anyways.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@SMillerDev
Copy link
Contributor

It's an external dependency. Check composer.json for the identifier. That should allow you to look it up on packagist.org

@Grotax
Copy link
Member

Grotax commented Jan 4, 2021

#961

@Grotax
Copy link
Member

Grotax commented Feb 16, 2021

#1164 fixes this partly but not fully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Impact API/Backend code enhancement help wanted
Projects
None yet
Development

No branches or pull requests

3 participants