Many RSS feeds missing icons

[peterwright1986]

IMPORTANT

Read and tick the following checkbox after you have created the issue or place an x inside the brackets ;)

• I have read the CONTRIBUTING.md and followed the provided tips
• I accept that the issue will be closed without comment if I do not check here
• I accept that the issue will be closed without comment if I do not fill out all items in the issue template.

Explain the Problem

This is more of a cosmetic issue but I noticed a number of my feeds are missing the website icon when I add them. For me this makes it easier to immediately identify a source when I'm scrolling throw News. I notice the same feed's icons appear when testing with other RSS readers. Is this a work in progress, or is it possible to manually add the icon to a feed, somehow?

Steps to Reproduce

As an example, if I subscribe to BBC news (http://feeds.bbci.co.uk/news/uk/rss.xml) the feed will be added correctly but an icon does not appear either in the web view or the 'News' Android App.

System Information

• News app version: 24.0.0
• Nextcloud version: 27.1.1
• Cron type: System cron
• OS and version: Official Docker container running on Synology NAS.

This aside, thanks for an awesome RSS reader!

[Grotax]

Yea that bbc one is tricky.

The codes debugging messages are not that nice, I will improve that a bit but I think the following happens with that feed.

1. feed has image which is downloaded and checked but it is not square so it is rejected
2. news asks lib to check for favicon instead but that subpage by the bbc apparently has none, technical site not needed I guess
3. feed has no icon

In this case its 120*60 and a gif :)

I don't have a strong opinion about the square requirement.
Maybe we could just remove it and let the frontend/clients handle it.

Opinions? @nextcloud/news

[peterwright1986]

Thanks for looking into this and apologies for the delayed reply. Relaxing the icon requirements would be nice, provided it doesn't break anything of course.

[Grotax]

The backend doesn't care about it, clients might handle it differently.

Maybe we can look at this after the new UI lands in the master branch.