Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problematic behavior of the "Share" button #2102

Open
IgorA100 opened this issue Feb 14, 2023 · 2 comments
Open

Problematic behavior of the "Share" button #2102

IgorA100 opened this issue Feb 14, 2023 · 2 comments
Labels
enhancement frontend impact Javascript/Frontend code

Comments

@IgorA100
Copy link
Contributor

IMPORTANT

  • [ x] I have read the CONTRIBUTING.md and followed the provided tips
  • [ x] I accept that the issue will be closed without comment if I do not check here
  • [ x] I accept that the issue will be closed without comment if I do not fill out all items in the issue template.

Explain the Problem

If you click the "Share" button, then there are two problems:

  1. The focus is NOT in the input field, and if you immediately start typing a name on the keyboard, then there is a transition to another feed"
  2. If you select a user and share a publication with him, then the user will not receive a notification by e-mail that they have been shared with him, this is very bad!!!

Steps to Reproduce

  1. When viewing the news feed, press the "Share" button and then immediately start typing the name of the person with whom you want to share.
  2. Once shared with someone, they will not receive an email notification.

System Information

  • News app version: 20.0.1
  • Nextcloud version: 25.0.3
  • Cron type: (system cron/python updater/...) cron
  • PHP version: 8.1.2
  • Database and version: PostgreSQL 14.4
  • Browser and version: Irrelevant
  • OS and version: Irrelevant
Contents of nextcloud/data/nextcloud.log
{"reqId":"rn18u3RtCQw56Ola4c99","level":3,"time":"2023-02-14T15:00:15+03:00","remoteAddr":"","user":"--","app":"news","method":"","url":"--","message":"Unable to receive content from /epz/order/notice/notice223/common-info.html?noticeInfoId=13821765","userAgent":"--","version":"25.0.3.2","data":{"app":"news"}}
{"reqId":"rn18u3RtCQw56Ola4c99","level":3,"time":"2023-02-14T15:00:15+03:00","remoteAddr":"","user":"--","app":"news","method":"","url":"--","message":"Unable to receive content from /epz/order/notice/notice223/common-info.html?noticeInfoId=13810276","userAgent":"--","version":"25.0.3.2","data":{"app":"news"}}
{"reqId":"rn18u3RtCQw56Ola4c99","level":3,"time":"2023-02-14T15:00:15+03:00","remoteAddr":"","user":"--","app":"news","method":"","url":"--","message":"Unable to receive content from /epz/order/notice/notice223/common-info.html?noticeInfoId=13810232","userAgent":"--","version":"25.0.3.2","data":{"app":"news"}}
{"reqId":"rn18u3RtCQw56Ola4c99","level":3,"time":"2023-02-14T15:00:15+03:00","remoteAddr":"","user":"--","app":"news","method":"","url":"--","message":"Unable to receive content from /epz/order/notice/notice223/common-info.html?noticeInfoId=13810161","userAgent":"--","version":"25.0.3.2","data":{"app":"news"}}
Contents of Browser Error Console Read http://ggnome.com/wiki/Using_The_Browser_Error_Console if you are unsure what to put here
No error.
@IgorA100 IgorA100 added the bug label Feb 14, 2023
@SMillerDev SMillerDev added the frontend impact Javascript/Frontend code label Feb 14, 2023
@IgorA100
Copy link
Contributor Author

I took a quick look at the code and it seems that notifications are not provided here at all :(.
It's very sad :(

@Grotax
Copy link
Member

Grotax commented Oct 26, 2023

For the notification we could use this: https://github.com/nextcloud/notifications/blob/master/docs/notification-workflow.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement frontend impact Javascript/Frontend code
Projects
None yet
Development

No branches or pull requests

3 participants