diff --git a/lib/Service/MailFilter/FilterBuilder.php b/lib/Service/MailFilter/FilterBuilder.php index 24e00c2d21..6d47c4e342 100644 --- a/lib/Service/MailFilter/FilterBuilder.php +++ b/lib/Service/MailFilter/FilterBuilder.php @@ -31,7 +31,7 @@ public function buildSieveScript(array $filters, string $untouchedScript): strin continue; } - $commands[] = '# Filter: ' . $filter['name']; + $commands[] = '# ' . $filter['name']; $tests = []; foreach ($filter['tests'] as $test) { diff --git a/tests/data/mail-filter/builder1.sieve b/tests/data/mail-filter/builder1.sieve index ddcde7d21e..d20750752a 100644 --- a/tests/data/mail-filter/builder1.sieve +++ b/tests/data/mail-filter/builder1.sieve @@ -4,7 +4,7 @@ require ["imap4flags"]; # Hello, this is a test ### Nextcloud Mail: Filters ### DON'T EDIT ### # FILTER: [{"name":"Test 1","enable":true,"operator":"allof","tests":[{"operator":"is","values":["alice@example.org","bob@example.org"],"field":"from"}],"actions":[{"type":"addflag","flag":"Alice and Bob"}],"priority":10}] -# Filter: Test 1 +# Test 1 if address :is :all "From" ["alice@example.org", "bob@example.org"] { addflag "$alice_and_bob"; } diff --git a/tests/data/mail-filter/builder2.sieve b/tests/data/mail-filter/builder2.sieve index 6616f03f2e..683739fc83 100644 --- a/tests/data/mail-filter/builder2.sieve +++ b/tests/data/mail-filter/builder2.sieve @@ -4,7 +4,7 @@ require ["fileinto"]; # Hello, this is a test ### Nextcloud Mail: Filters ### DON'T EDIT ### # FILTER: [{"name":"Test 2","enable":true,"operator":"anyof","tests":[{"operator":"contains","values":["Project-A","Project-B"],"field":"subject"},{"operator":"is","values":["john@example.org"],"field":"from"}],"actions":[{"type":"fileinto","mailbox":"Test Data"}],"priority":20}] -# Filter: Test 2 +# Test 2 if anyof (header :contains "Subject" ["Project-A", "Project-B"], address :is :all "From" ["john@example.org"]) { fileinto "Test Data"; } diff --git a/tests/data/mail-filter/builder3.sieve b/tests/data/mail-filter/builder3.sieve index 11c8e3c4bd..71c197d181 100644 --- a/tests/data/mail-filter/builder3.sieve +++ b/tests/data/mail-filter/builder3.sieve @@ -4,12 +4,12 @@ require ["fileinto", "imap4flags"]; # Hello, this is a test ### Nextcloud Mail: Filters ### DON'T EDIT ### # FILTER: [{"name":"Test 3.1","enable":true,"operator":"anyof","tests":[{"operator":"contains","values":["Project-A","Project-B"],"field":"subject"},{"operator":"is","values":["john@example.org"],"field":"from"}],"actions":[{"type":"fileinto","mailbox":"Test Data"},{"type":"stop"}],"priority":20},{"name":"Test 3.2","enable":true,"operator":"allof","tests":[{"operator":"contains","values":["@example.org"],"field":"to"}],"actions":[{"type":"addflag","flag":"Test A"}],"priority":30}] -# Filter: Test 3.1 +# Test 3.1 if anyof (header :contains "Subject" ["Project-A", "Project-B"], address :is :all "From" ["john@example.org"]) { fileinto "Test Data"; stop; } -# Filter: Test 3.2 +# Test 3.2 if address :contains :all "To" ["@example.org"] { addflag "$test_a"; } diff --git a/tests/data/mail-filter/builder4.sieve b/tests/data/mail-filter/builder4.sieve index b0bb67e60e..2877d7de01 100644 --- a/tests/data/mail-filter/builder4.sieve +++ b/tests/data/mail-filter/builder4.sieve @@ -1,6 +1,6 @@ # Hello, this is a test ### Nextcloud Mail: Filters ### DON'T EDIT ### # FILTER: [{"actions":[{"flag":"Flag 123","type":"addflag"}],"enable":true,"name":"Test 4","operator":"allof","priority":60,"tests":[]}] -# Filter: Test 4 +# Test 4 # No valid tests found ### Nextcloud Mail: Filters ### DON'T EDIT ### diff --git a/tests/data/mail-filter/builder5.sieve b/tests/data/mail-filter/builder5.sieve index a8827d34ed..8aad19b928 100644 --- a/tests/data/mail-filter/builder5.sieve +++ b/tests/data/mail-filter/builder5.sieve @@ -4,7 +4,7 @@ require ["imap4flags"]; # Hello, this is a test ### Nextcloud Mail: Filters ### DON'T EDIT ### # FILTER: [{"actions":[{"flag":"Report","type":"addflag"},{"flag":"To read","type":"addflag"}],"enable":true,"name":"Test 5","operator":"allof","priority":10,"tests":[{"field":"subject","operator":"matches","values":["work*report"]}]}] -# Filter: Test 5 +# Test 5 if header :matches "Subject" ["work*report"] { addflag "$report"; addflag "$to_read"; diff --git a/tests/data/mail-filter/builder6.sieve b/tests/data/mail-filter/builder6.sieve index 5d497182ee..e5a756d66e 100644 --- a/tests/data/mail-filter/builder6.sieve +++ b/tests/data/mail-filter/builder6.sieve @@ -4,7 +4,7 @@ require ["fileinto", "imap4flags"]; # Hello, this is a test ### Nextcloud Mail: Filters ### DON'T EDIT ### # FILTER: [{"actions":[{"mailbox":"Test Data","type":"fileinto"},{"flag":"Projects\\Reporting","type":"addflag"}],"enable":true,"name":"Test 6","operator":"anyof","priority":10,"tests":[{"field":"subject","operator":"is","values":["\"Project-A\"","Project\\A"]},{"field":"subject","operator":"is","values":["\"Project-B\"","Project\\B"]}]}] -# Filter: Test 6 +# Test 6 if anyof (header :is "Subject" ["\"Project-A\"", "Project\\A"], header :is "Subject" ["\"Project-B\"", "Project\\B"]) { fileinto "Test Data"; addflag "$projects\\reporting"; diff --git a/tests/data/mail-filter/parser1.sieve b/tests/data/mail-filter/parser1.sieve index 657d20ed2a..d20750752a 100644 --- a/tests/data/mail-filter/parser1.sieve +++ b/tests/data/mail-filter/parser1.sieve @@ -3,8 +3,8 @@ require ["imap4flags"]; ### Nextcloud Mail: Filters ### DON'T EDIT ### # Hello, this is a test ### Nextcloud Mail: Filters ### DON'T EDIT ### -# DATA: [{"name":"Test 1","enable":true,"operator":"allof","tests":[{"operator":"is","values":["alice@example.org","bob@example.org"],"field":"from"}],"actions":[{"type":"addflag","flag":"Alice and Bob"}],"priority":10}] -# Filter: Test 1 +# FILTER: [{"name":"Test 1","enable":true,"operator":"allof","tests":[{"operator":"is","values":["alice@example.org","bob@example.org"],"field":"from"}],"actions":[{"type":"addflag","flag":"Alice and Bob"}],"priority":10}] +# Test 1 if address :is :all "From" ["alice@example.org", "bob@example.org"] { addflag "$alice_and_bob"; } diff --git a/tests/data/mail-filter/parser2.sieve b/tests/data/mail-filter/parser2.sieve index 9fbf715fb8..10e91a2543 100644 --- a/tests/data/mail-filter/parser2.sieve +++ b/tests/data/mail-filter/parser2.sieve @@ -3,8 +3,8 @@ require ["fileinto"]; ### Nextcloud Mail: Filters ### DON'T EDIT ### # Hello, this is a test ### Nextcloud Mail: Filters ### DON'T EDIT ### -# DATA: [{"name":"Test 2","enable":true,"operator":"anyof","tests":[{"operator":"contains","values":["Project-A","Project-B"],"field":"subject"},{"operator":"is","values":["john@example.org"],"field":"from"}],"actions":[{"type":"fileinto","flag":"","mailbox":"Test Data"}],"priority":20}] -# Filter: Test 2 +# FILTER: [{"name":"Test 2","enable":true,"operator":"anyof","tests":[{"operator":"contains","values":["Project-A","Project-B"],"field":"subject"},{"operator":"is","values":["john@example.org"],"field":"from"}],"actions":[{"type":"fileinto","flag":"","mailbox":"Test Data"}],"priority":20}] +# Test 2 if anyof (header :contains "Subject" ["Project-A", "Project-B"], address :is :all "From" ["john@example.org"]) { fileinto "Test Data"; }