Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacer regex will not match K8s labels. #372

Open
ericmittelhammer opened this issue Apr 7, 2021 · 0 comments
Open

Replacer regex will not match K8s labels. #372

ericmittelhammer opened this issue Apr 7, 2021 · 0 comments
Labels
feature request Categorizes issue or PR as related to a new feature or enhancement. triage/pending Issue or PR is pending for triage and prioritization.

Comments

@ericmittelhammer
Copy link

infrastructure-agent/pkg/databind/pkg/databind/replacer.go

Line 26 in 1ad558d

var regex = regexp.MustCompile(`\$\{[\w\d\._\s\[\]-]*\}`)

Labels applied by the control plane follow a convention of prefix/label. The regex here fails to match because of the slash.
@josemore josemore added hero to be considered in hero rotation feature request Categorizes issue or PR as related to a new feature or enhancement. labels May 19, 2021
@davidgit davidgit removed the hero to be considered in hero rotation label Jun 9, 2021
@davidgit davidgit added the triage/pending Issue or PR is pending for triage and prioritization. label Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Categorizes issue or PR as related to a new feature or enhancement. triage/pending Issue or PR is pending for triage and prioritization.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@davidgit @ericmittelhammer @josemore