Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add split_by_group, highpass_spatial_filter, silence_periods, detect_bad_channels #51

Open
JoeZiminski opened this issue Jul 27, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@JoeZiminski
Copy link
Member

These are useful preprocessing steps it would be nice to expose, but they require some care.

Highpass Spatial Filter

This requires the recording to be split-by-group (see below).

Split by Group

This is nice as it allows reprocessing to be performed per-group i.e. per-shank. However, I am not currently sure whether all preproecssing should be performed split by group, and how to handle sorting that is split-by-group. Need to ask on Slack. Handling group splitting is straightforward (it returns a dict of recording objects) thanks to SI's nice API.

silence_periods

This led to some problems with other preprocessing steps, is not a key step and is difficult to get the syntax for the arguments (nested list) correct in .yaml, so leaving this for now

detect_bad_channels

This is sensitive to the preproecssing steps and SI usually run after phase shift and filtering, but before CAR. There is a decision to be made as to whether detect_bad_channels is always run after some fixed preproecssing steps (e.g. filtering), or can be dynamically run as some point in a user preprocessing chain depending on input arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant