Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luigi vs luigi2 #12

Open
ChrisDownUnder opened this issue Oct 4, 2022 · 0 comments
Open

luigi vs luigi2 #12

ChrisDownUnder opened this issue Oct 4, 2022 · 0 comments

Comments

@ChrisDownUnder
Copy link
Contributor

Hi nakst

With luigi2 being the actively developed version of this library, I was wondering:

  • are you planning to remove the luigi header and examples to focus only on luigi2, or
  • are you planning to have them co-exist for some time going forward?

The reason I ask is to do with incompatibilities (or just new APIs) between luigi2 and luigi + it's examples.

The current luigi examples do not compile with luigi2 for two main reasons that I can see:

  1. the ColorPicker element isn't present in luigi2
  2. the change from UI_PANEL_GRAY/WHITE to UI_PANEL_COLOR_1/2.

Proposal

If you are planning to keep luigi and luigi2 coexisting, could I suggest adding a 'luigi2_example.c' file to the repository to compile against luigi2? This would also allow further updates to the example to showcase luigi2 improvements without breaking the luigi example.

If you are keeping both versions of the library, see my Luigi1 - backport luigi2 fixes pull request with a few small quality of life improvements in case anyone uses the luigi1 header and examples -- for your consideration.

Note: See my other raised issue/pull request, which includes proposed luigi2 element updates along with an updated version of 'luigi2_example.c' demonstrating those features.

Regards,
OzChris / ChrisDownUnder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant