Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Range HTTP header perhaps unnecessarily blocked #324

Open
justparking opened this issue May 10, 2024 · 0 comments
Open

Range HTTP header perhaps unnecessarily blocked #324

justparking opened this issue May 10, 2024 · 0 comments

Comments

@justparking
Copy link
Contributor

This was experienced when trying to host a MP4 video file.

When using Chrome, it automatically uses this Range: bytes=0- header which seems to trip up Nodel HTTP server.

It returns a misleading error code 404 NOT FOUND but looking deeper in the code, it's actually supposed to return INTERNAL ERROR: 'range' not supported in this context. (related code

)

Nodel definitely has code to support (even partially support) the Range header - doco.

I presume browsers make use it to provide file seeking which is different to other content types.

I'm not sure if there was a particular reason why Range was specifically being ignored.

I tested removing that check and it works fine but I need to check for other side-effects.

@justparking justparking self-assigned this May 10, 2024
justparking added a commit to automaticau/nodel that referenced this issue Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant