Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call the browse_all function only from regions/shelves.py; remove it elsewhere #112

Open
AlexandraMoga opened this issue Feb 12, 2021 · 3 comments
Open

Call the browse_all function only from regions/shelves.py; remove it elsewhere #112

AlexandraMoga opened this issue Feb 12, 2021 · 3 comments
Assignees
@AlexandraMoga
Labels
enhancement New feature or request

Comments

@AlexandraMoga
Copy link
Contributor

We are currently calling the browse_all function both from pages/home.py and from regions/shelves.py. We should avoid duplications and use only the function in regions/shelves.py because it is a shelf specific function.
@AlexandraMoga AlexandraMoga added the enhancement New feature or request label Feb 12, 2021
@AlexandraMoga AlexandraMoga self-assigned this Feb 12, 2021
@KushalBeniwal
Copy link
Contributor

@AlexandraMoga if no-one is working on it then I would like to work on this issue.

@AlexandraMoga
Copy link
Contributor Author

@KushalBeniwal Thanks for your interest in helping with this issue. There have been a few changes that affect this component which I would like to revisit myself. It is not as straightforward as I thought in the beginning.

@addymistrel
Copy link

I have gone thorugh the issue and it would be wonderful if I get to work on this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexandraMoga AlexandraMoga

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AlexandraMoga @KushalBeniwal @addymistrel