Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leak due to event handler #20

Open
ghost opened this issue May 15, 2020 · 2 comments
Open

Memory leak due to event handler #20

ghost opened this issue May 15, 2020 · 2 comments
Labels
bug Something doesn't function as intended

Comments

@ghost
Copy link

ghost commented May 15, 2020

Here's a memory leak:

Modern.Forms/src/Modern.Forms/Control.cs

Line 53 in 51f917a

Theme.ThemeChanged += (o, e) => is_dirty = true;

@jpobst jpobst added the bug Something doesn't function as intended label May 16, 2020
@jpobst
Copy link
Collaborator

jpobst commented May 16, 2020

Nice catch! I'll have to give some thought to how I want to fix this.

@jpobst jpobst changed the title Memory leak Memory leak due to event handler May 16, 2020
@jzlhll
Copy link

jzlhll commented May 18, 2020 •
edited
Loading

Sound like singleInstance add handler once again.
Maybe should remove it before add or only add once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something doesn't function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpobst @jzlhll