Deprecation Warning for sass #4054
Comments
|
I see this too. Would you appreciate a PR for this? I can do it. |
|
yes, me too |
|
same |
I would love a PR. I could struggle through it, but you could probably do a much better job of it. |
|
ok, @mattrose, to be specific, I was asking the maintainer of the repo @mmistakes if he would accept one, because I would like to see if it's worth the effort. |
|
I saw similar issues after doing a |
|
jekyll-sass-converter was updated to use a different implimentation of Sass. This is why you're seeing warnings and errors because the Sass written for this theme uses the Ruby version (now deprecated) and would need to be refactored to support Dart Sass. The problem with doing this is remote theme version which leans on the github-pages gem doesn't use the latest and greatest version of Jekyll or jekyll-sass-converter. So I don't think the Sass can be updated as it would break for the tons of users building sites on GH Pages. The solution is to lock jekyll-sass-converter to the previous version. |
I doubt that Besides, remote-theme users have the option to lock to a working git ref of the theme as well. |
|
@ashmaroli Completely agree on that. Just makes my head hurt thinking about the thousands of users who have no clue they can lock a remote-theme or that they'd be better served using GitHub Actions and the latest version of Jekyll instead of relying on Which means the potential for a lot of broken site builds. |
|
+1 |
|
To anyone interested in submitting a pull request, you may try updating the theme documentation to recommend setting # _config.yml
sass:
quiet_deps: true # Disable printing deprecation warnings to terminal |
|
I guess the question of whether to update this theme to support dart sass or not comes down to whether the theme should pin itself to old versions of dependencies to remain compatible with old gh_pages users, or should look to move forward with dependencies. IMHO, I think there is a strong argument to move forward with dependencies. New users should build github pages via actions, so things will work fine for them. Existing users using actions are also OK with this. It's only existing users using the out dated way of building GH pages that are affected. I'd document they have two options:
Personally, keeping this theme up to date is much better than pinning it in the past, just for the sake of users using outdated ways of using the theme, who have the two above choices to work around things. To put this another way, you've got two broad sets of users: those updating dependencies & processes and those that don't. The first group is being affected by this issue as they're trying to do the right thing and keep things up to date. Where are the second group probably are mostly unaware of the issue as they don't update their dependencies, including the theme version. |
Because updating to Jekyll v4.3.2 causes sass warnings. ref) mmistakes/minimal-mistakes#4054 (comment)
Because updating to Jekyll v4.3.2 causes sass warnings. ref) mmistakes/minimal-mistakes#4054 (comment)
[dc9687d] _config: "sass: quiet_deps: true" As per mmistakes/minimal-mistakes#4054 (comment)
Updating to Jekyll 4.3.0 and above causes build warnings as this converter has switched to a different implementation (sass-embedded). [0] As the theme is intended to be GitHub Pages compatible (which, by the way, has a horribly outdated Jekyll version), these warnings are not avoidable on later Jekyll versions which have added support for the latest version of jekyll-sass-converter. Since Jekyll still supports the older, now-deprecated sassc-based version [1], let's just keep it that way. [0]: mmistakes/minimal-mistakes#4054 [1]: https://github.com/jekyll/jekyll/blob/v4.3.2/jekyll.gemspec#L39
Updating to Jekyll 4.3.0 and above causes build warnings as this converter has switched to a different implementation (sass-embedded). [0] As the theme is intended to be GitHub Pages compatible (which, by the way, has a horribly outdated Jekyll version), these warnings are not avoidable on later Jekyll versions which have added support for the latest version of jekyll-sass-converter. Since Jekyll still supports the older, now-deprecated sassc-based version [1], let's just keep it that way. [0]: mmistakes/minimal-mistakes#4054 [1]: https://github.com/jekyll/jekyll/blob/v4.3.2/jekyll.gemspec#L39
We want to be up to date. So I updated Jekyll to the latest version. [1] Lately, we have been favoring GitHub Actions over the built-in GitHub Pages. I also switched the theme from the remote version to the version installed from the gem. This forced us to make a few configuration changes. We had to add a few gems that were previously loaded via GitHub Pages. Additionally, there were deprecation warnings related to Sass gem. [2] This in turn made me have to add `jekyll-sass-converter` gem [3] in a specific version. After these changes, everything works. However, there is definitely space for optimization. [1]: https://rubygems.org/gems/jekyll [2]: mmistakes/minimal-mistakes#4054 [3]: jekyll/jekyll-sass-converter#145 (comment)
The reason is the previously mentioned problem. [1] [2] [1]: mmistakes/minimal-mistakes#4054 [2]: jekyll/jekyll-sass-converter#145 (comment)
|
I am also in favour of updating to the newer versions, as over time more and more other features will require them. It would be good to get a maintainer call on this before someone does the work. |
|
So what is the recommended path forward on this? I saw some suggestions, but not sure what the best path forward is. I can certainly silence the deprecation warnings (and will temporarily), but that seems fraught with peril. |
|
I wonder how many people buying him a coffee would be enough to encourage him to spend some time on this? :) |
|
add @use "sass:math"; in minimal-mistakes.scss |
Updating to Jekyll 4.3.0 and above causes build warnings as this converter has switched to a different implementation (sass-embedded). [0] As the theme is intended to be GitHub Pages compatible (which, by the way, has a horribly outdated Jekyll version), these warnings are not avoidable on later Jekyll versions which have added support for the latest version of jekyll-sass-converter. Since Jekyll still supports the older, now-deprecated sassc-based version [1], let's just keep it that way. [0]: mmistakes#4054 [1]: https://github.com/jekyll/jekyll/blob/v4.3.2/jekyll.gemspec#L39
Updating to Jekyll 4.3.0 and above causes build warnings as this converter has switched to a different implementation (sass-embedded). [0] As the theme is intended to be GitHub Pages compatible (which, by the way, has a horribly outdated Jekyll version), these warnings are not avoidable on later Jekyll versions which have added support for the latest version of jekyll-sass-converter. Since Jekyll still supports the older, now-deprecated sassc-based version [1], let's just keep it that way. [0]: mmistakes#4054 [1]: https://github.com/jekyll/jekyll/blob/v4.3.2/jekyll.gemspec#L39
Does this work with sassc though? |
What happened?
Expected behavior
expected output: (ignore the remote: part)
Steps to reproduce the behavior
Multiple instances of: Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0. like this
Other
Full out:
The text was updated successfully, but these errors were encountered: