From a778a1eaf9f2051e822527a9bc5acbac50df5883 Mon Sep 17 00:00:00 2001
From: Kaan Kabalak <kaan@minio.io>
Date: Fri, 21 Jan 2022 15:21:28 -0800
Subject: [PATCH] Fix failing tests and remove sleep statement for GitHub
 Actions (#1432)

---
 .github/workflows/permissions.yml          |  2 +-
 portal-ui/tests/permissions/diagnostics.ts | 28 ++++++++++------------
 2 files changed, 14 insertions(+), 16 deletions(-)

diff --git a/.github/workflows/permissions.yml b/.github/workflows/permissions.yml
index 0fabf8ca05..d550bf41d7 100644
--- a/.github/workflows/permissions.yml
+++ b/.github/workflows/permissions.yml
@@ -58,7 +58,7 @@ jobs:
 
       - name: Start Console, front-end app and initialize users/policies
         run: |
-          (./console server && sleep 180) & (make initialize-permissions && sleep 180)
+          (./console server) & (make initialize-permissions)
 
       - name: Run TestCafe Tests
         uses: DevExpress/testcafe-action@latest
diff --git a/portal-ui/tests/permissions/diagnostics.ts b/portal-ui/tests/permissions/diagnostics.ts
index c19eadc8eb..506fa30709 100644
--- a/portal-ui/tests/permissions/diagnostics.ts
+++ b/portal-ui/tests/permissions/diagnostics.ts
@@ -60,22 +60,20 @@ test("Start Diagnostic button can be clicked", async (t) => {
     .click(elements.startDiagnosticButton);
 });
 
-// TODO: Fix test failing sporadically on GitHub Actions
-
-// test("Download button exists after Diagnostic is completed", async (t) => {
-//   const downloadExists = elements.downloadButton.exists;
-//   await t
-//     .navigateTo("http://localhost:9090/support/diagnostics")
-//     .click(elements.startDiagnosticButton)
-//     .expect(downloadExists).ok();
-// });
+test("Download button exists after Diagnostic is completed", async (t) => {
+  const downloadExists = elements.downloadButton.exists;
+  await t
+    .navigateTo("http://localhost:9090/support/diagnostics")
+    .click(elements.startDiagnosticButton)
+    .expect(downloadExists).ok();
+});
 
-// test("Download button is clickable after Diagnostic is completed", async (t) => {
-//   await t
-//     .navigateTo("http://localhost:9090/support/diagnostics")
-//     .click(elements.startDiagnosticButton)
-//     .click(elements.downloadButton);
-// });
+test("Download button is clickable after Diagnostic is completed", async (t) => {
+  await t
+    .navigateTo("http://localhost:9090/support/diagnostics")
+    .click(elements.startDiagnosticButton)
+    .click(elements.downloadButton);
+});
 
 test("Start New Diagnostic button exists after Diagnostic is completed", async (t) => {
   const startNewDiagnosticButtonExists =