Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

farming canntot be updated - vs feature for rubenwardy/food modpack and food_sweet #105

Open
5 tasks
bell07 opened this issue Jun 21, 2022 · 2 comments · May be fixed by #209
Open
5 tasks

farming canntot be updated - vs feature for rubenwardy/food modpack and food_sweet #105

bell07 opened this issue Jun 21, 2022 · 2 comments · May be fixed by #209

Comments

@bell07
Copy link
Collaborator

bell07 commented Jun 21, 2022

The food modpack and food_sweet are archived and not maintained anymore. So we need to look for replacements.
Related known issue is #59 Craft conflict between food:egg and lemon

New related issue appears with farming mod:

https://notabug.org/TenPlus1/farming/commit/ba0ef644a0509bf68f132f17ffd769ab8fed0070
Tenplus does not use the group:food_milk (that was provided by food_basic) but mobs:bucket_milk, that is currently not in whynot.

https://notabug.org/TenPlus1/farming/commit/7f9727cebc63d45c83a3bcbe9d76be1cdc10b670
mobs:wooden_bucket_milk instead of group:food_milkbucket
By the way, we do not have any mod that provides group:food_milkbucket, so some recipes are not crafteable :-(

So we need to search for alternatives. Till alternative is found I set the last working farming commit into check-updates.sh


  • Replace or remove food modpack and food_sweet
  • If we keep them and don't add mobs_animal
    • Make alias of mobs:bucket_milk to a milk provided by the food mods (or replace crafting recipes)
    • Add group:food_milkbucket
    • Make alias of mobs:wooden_bucket_milk to a milk bucket provided by the food mods (or replace crafting recipes)
  • If we keep them and do add mobs_animal
    • Add mobs:bucket_milk to group:food_milk
    • Add group:food_milkbucket
    • Add mobs:wooden_bucket to group:food_milkbucket
    • Potentially still fix some recipes
  • If we remove them and don't add mobs_animal
    • Wouldn't work. No milk.
  • If we remove them and do add mobs_animal
    • Alias all things provided by the food modpack and food sweet to other foods from other mods.
@Lazerbeak12345
Copy link
Collaborator

Added some tasks to objectify the issue.

@dacmot
Copy link
Collaborator

dacmot commented Oct 5, 2024

I updated farming and got no issues so far from admittedly short playtesting. I also ran the qa_block functions but it didn't seem to find any of the issues listed here. Comparing before and after I only got the diff below.

Maybe somehow we've been running a version of farming with the bucket issues all along?

--- qa_block_prefarmingupdate.log     2024-10-04 21:38:24.855016470 -0400
+++ qa_block_postfarmingupdate.log    2024-10-04 22:19:31.777965668 -0400
@@ -1,5 +1,6 @@
 QA check broken_recipe started.
 Input group without any items: "food_chicken_raw" (full string: "group:food_chicken_raw")
+Input group without any items: "food_olive_oil" (full string: "group:food_olive_oil")
 Input group without any items: "food_seaweed" (full string: "group:food_seaweed")
 Input group without any items: "food_milkbucket" (full string: "group:food_milkbucket")
 Unknown input item: "moreblocks:slab_wood"
@@ -96,7 +97,8 @@
 Maybe redundant door4_locked   my_castle_doors:door4_locked    my_old_doors:door4_locked
 QA check redundant_items finished.
 QA check same_recipe started.
+same recipe    bonemeal:bone 2 heads:head_1
 same recipe    laptop:HDD      laptop:bat
 same recipe    homedecor:cobweb_corner 5       mobs:cobweb
 QA check same_recipe finished.
 QA check unobtainable_items started.
@@ -203,7 +205,6 @@
 farming:mint_leaf
 farming:pineapple_top
 farming:scythe_mithril
-farming:seed_mint
 fire:permanent_flame
 home_vending_machines:soda_can
 home_vending_machines:water_bottle
@@ -250,2 +249,2 @@
 QA check unobtainable_items finished.	
 QA check useless_items started.
@@ -352,12 +353,11 @@
 clothing:shirt_violet
 clothing:shirt_white
 clothing:shirt_yellow
+farming:butter_vegan
 farming:cornstarch
+farming:glass_water
 farming:mint_leaf
 farming:pasta
-farming:pot
-farming:saucepan
-farming:skillet
 food:bowl
 food:butter
 food:chocolate_powder

@dacmot dacmot linked a pull request Oct 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants