Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chat file references should not use bold for icons #230395

Closed
Tyriar opened this issue Oct 3, 2024 · 1 comment · Fixed by #230421
Closed

Chat file references should not use bold for icons #230395

Tyriar opened this issue Oct 3, 2024 · 1 comment · Fixed by #230421
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders panel-chat verified Verification succeeded
Milestone
October 2024

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 3, 2024

Left side icons are bold and they look wrong/blurry because of it:

Image
@mjbvz mjbvz added this to the October 2024 milestone Oct 3, 2024
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Oct 3, 2024
@mjbvz
Copy link
Collaborator

mjbvz commented Oct 3, 2024

Originally as-design for the text since it comes from the markdown. However the icons is definitely a bug and I'm reconsidering allowing the text to be bold too

mjbvz added a commit that referenced this issue Oct 3, 2024
@mjbvz
Don't allow bold inline anchors
9ad0d97 
Fixes #230395
@mjbvz mjbvz mentioned this issue Oct 3, 2024
Merged
@mjbvz mjbvz closed this as completed in a1c1c56 Oct 3, 2024
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Oct 3, 2024
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 4, 2024
@rzhao271 rzhao271 added the verified Verification succeeded label Oct 23, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Nov 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders panel-chat verified Verification succeeded
Projects
None yet
Milestone
October 2024
Development

Successfully merging a pull request may close this issue.

Don't allow bold inline anchors microsoft/vscode
3 participants
@Tyriar @rzhao271 @mjbvz