Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider a different setting name for shell integration settings #24143

Closed
Tyriar opened this issue Sep 20, 2024 · 0 comments · Fixed by #24153
Closed

Consider a different setting name for shell integration settings #24143

Tyriar opened this issue Sep 20, 2024 · 0 comments · Fixed by #24153
Assignees
@anthonykim1
Labels
area-repl area-terminal feature-request Request for new features or functionality needs PR Ready to be worked on

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 20, 2024

Currently we have python.REPL.enableShellIntegration. The upcoming change doesn't just apply to the "Python REPL" feature but to all terminals. So I would put it beside the other terminal settings like python.terminal.enableShellIntegration.

Also VS Code core has this as terminal.integrated.shellIntegration.enabled, we should use python.terminal.shellIntegration.enabled if we expect more settings related to shell integration, rather than just the single enablement.
@Tyriar Tyriar added the feature-request Request for new features or functionality label Sep 20, 2024
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Sep 20, 2024
@anthonykim1 anthonykim1 mentioned this issue Sep 23, 2024
Merged
@anthonykim1 anthonykim1 added area-terminal area-repl needs PR Ready to be worked on and removed triage-needed Needs assignment to the proper sub-team labels Sep 23, 2024
anthonykim1 added a commit that referenced this issue Sep 23, 2024
@anthonykim1 @Tyriar
Change PYTHONSTARTUP setting name to Python.terminal.shell integratio…
f8b861a 
…n.enabled (#24153)

Resolves: #24143 
/cc @cwebster-99 @Tyriar

---------

Co-authored-by: Daniel Imms <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anthonykim1 anthonykim1

Labels
area-repl area-terminal feature-request Request for new features or functionality needs PR Ready to be worked on
Projects
None yet
Milestone
No milestone
2 participants
@Tyriar @anthonykim1