Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Tests only open on double click #21501

Closed
joaomoreno opened this issue Jun 27, 2023 · 3 comments
Closed

Testing: Tests only open on double click #21501

joaomoreno opened this issue Jun 27, 2023 · 3 comments
Labels
triage-needed Needs assignment to the proper sub-team

Comments

@joaomoreno
Copy link
Member

Testing #21494

Screen.Recording.2023-06-27.at.10.28.13.mov

This feels very strange, was it always like that? All other views open on single click. We even have a workbench-wide setting for this behavior:

image
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Jun 27, 2023
@joaomoreno
Copy link
Member Author

Actually if the test was reported to having failed, it opens as expected. 🤷

@connor4312
Copy link
Member

Yea, this is intended. We actually used to do this, but there was an issue a while ago that because clicking a test can also be used to toggle its expand/collapsed state, navigating to the file when a user clicks on it can be unintended or disruptive. As you found, it can be navigated to via a double click, alt+enter when selected, or the "go to test" action.

The navigation on failed state is kind of a carryover from before we had a persistent "test results" view.

@joaomoreno
Copy link
Member Author

joaomoreno commented Jun 27, 2023

clicking a test can also be used to toggle its expand/collapsed state

Outline had the same problem. We fixed it by adding a mode in which clickable branches would only expand/collapse when hitting the twistie. Ie:

  • Clicking the row should open it.
  • Clicking the twistie should expand/collapse it.

Could/should we adopt that mode here?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
triage-needed Needs assignment to the proper sub-team
Projects
None yet
Development

No branches or pull requests

2 participants