From 34739e6c45bcae197eb1bad1f0b074355bdcc8c6 Mon Sep 17 00:00:00 2001 From: Andy Holmes Date: Tue, 29 Oct 2019 12:04:53 -0400 Subject: [PATCH 1/2] HCP for android emulator --- src/android/AssetBundle.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/android/AssetBundle.java b/src/android/AssetBundle.java index 54e8077..966cf03 100644 --- a/src/android/AssetBundle.java +++ b/src/android/AssetBundle.java @@ -191,7 +191,7 @@ public String getRootUrlString() { JSONObject runtimeConfig = getRuntimeConfig(); if (runtimeConfig != null) { try { - rootUrlString = runtimeConfig.getString("ROOT_URL"); + rootUrlString = runtimeConfig.getString("ROOT_URL").replace("localhost","10.0.2.2"); } catch (JSONException e) { Log.w(LOG_TAG, "Error reading ROOT_URL from runtime config", e); } From 8c58b071c9fbbbba701c42ebd8425785d7cac5ab Mon Sep 17 00:00:00 2001 From: Andy Holmes Date: Tue, 19 Nov 2019 13:16:43 -0500 Subject: [PATCH 2/2] Extracted constants per @felipenevola request --- src/android/AssetBundle.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/android/AssetBundle.java b/src/android/AssetBundle.java index 966cf03..67f5cf9 100644 --- a/src/android/AssetBundle.java +++ b/src/android/AssetBundle.java @@ -191,7 +191,10 @@ public String getRootUrlString() { JSONObject runtimeConfig = getRuntimeConfig(); if (runtimeConfig != null) { try { - rootUrlString = runtimeConfig.getString("ROOT_URL").replace("localhost","10.0.2.2"); + const localhost = "localhost"; + const emulatorHostLoopbackAddr = "10.0.2.2"; + let rootUrlStringOrig = runtimeConfig.getString("ROOT_URL"); + rootUrlString = rootUrlStringOrig.replace( localhost, emulatorHostLoopbackAddr ); } catch (JSONException e) { Log.w(LOG_TAG, "Error reading ROOT_URL from runtime config", e); }