Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explore automatically injecting Puck styles #568

Open
chrisvxd opened this issue Aug 15, 2024 · 0 comments
Open

Explore automatically injecting Puck styles #568

chrisvxd opened this issue Aug 15, 2024 · 0 comments
Labels
ready Assumed ready enough to start type: feature

Comments

@chrisvxd
Copy link
Member

Instead of relying on the user to import the Puck styles, we should explore injecting the style using JavaScript at run-time. This has several advantages:

  1. Styles won't end up in user's production bundles, improving performance
  2. Easier setup
  3. More targeted style injection for iframes
@chrisvxd chrisvxd added ready Assumed ready enough to start type: feature labels Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ready Assumed ready enough to start type: feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrisvxd