Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unauthenticated media #1825

Open
tusooa opened this issue Sep 14, 2024 · 7 comments
Open

Support unauthenticated media #1825

tusooa opened this issue Sep 14, 2024 · 7 comments
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements.

Comments

@tusooa
Copy link

tusooa commented Sep 14, 2024

I do not want authenticated media, please give back the media_url configuration.

@funderscore1
Copy link

They probably won't support that config. I think Synapse is going to drop it too.

@tusooa
Copy link
Author

tusooa commented Sep 14, 2024

They probably won't support that config. I think Synapse is going to drop it too.

Then it defeats the whole purpose of running this bridge. I want the media to be accessible from the irc side for as long as my server exists. If synapse is going to drop that support, I am going to run the appservice on conduwuit instead.

@funderscore1
Copy link

funderscore1 commented Sep 15, 2024

This bridge may spit out invalid matrix IDs which may not work on Conduwuit, see: #1780 It is in violation of the spec, and as far as I know the only Matrix homeserver that does not care is Synapse.

@girlbossceo
Copy link

We (conduwuit) can consider a workaround for the username capitalisation issue if they refuse to fix this. Judging by how long the issue has been open for, I think they are uninterested for some reason even though it would be a very trivial fix.

@Half-Shot Half-Shot added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements. label Sep 18, 2024
@Half-Shot
Copy link
Contributor

Half-Shot commented Sep 18, 2024

Hi folks, to address a few of the things raised here. Formally Matrix is moving to a model where all media is authenticated, and the bridge tries not to diverge from the spec (it is there for a reason after all).

The username violation is a bug with the bridge that we've just not had the resources to fix. I don't want to get into it here in this issue but formally the usage of nicknames in mxids is a mistake we've needed to clear up for a long time. It's certainly not an indicator that the bridge is willing to break the spec in the future.

That said, the underlying library for the media proxy supports omitting the TTL to make the media links valid forever (or at least as long as your IRC server is up). Unfortunately this didn't make it's way as far as this bridge, but that's correctable. You can also set the ttlSeconds to something extreme like 9007199254740991 (Number.MAX_SAFE_INTEGER) and it'll last until the next ice age.

This doesn't solve the concern that your IRC server might not live as long as your Matrix server, but unfortunately that's out of scope for this.

@funderscore1
Copy link

To be clear, I did not mean to say they are intentionally violating the spec, just that at the moment there is that bug.

@mweinelt
Copy link
Contributor

We tried using it with a ttl of 0, for which the matrix-appservice-bridge seems to have special handling. But sometime links still appear as expired, which is somewhat surprising.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements.
Projects
None yet
Development

No branches or pull requests

5 participants