New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tokens package #361

Open

kegsay opened this issue Apr 14, 2023 · 0 comments

Member

kegsay commented Apr 14, 2023

GMSL is for federation only.

Usages:

https://github.com/matrix-org/dendrite/blob/main/clientapi/routing/server_notices.go#L26 - GenerateLoginToken is called and the token passed to userapi.PerformDeviceCreationRequest
https://github.com/matrix-org/dendrite/blob/main/clientapi/routing/register.go#L40 - same thing but only for guests. Normal users use token, err := auth.GenerateAccessToken(). We should use that instead in all cases.

History:

This package was added in 2019.
Intended to be used as macaroons (which are no longer used in Synapse)
Allows verification of tokens without DB hits.
In practice we do DB hits and string compare.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment