Recognise "method" keyword as a subroutine

[davorg]

I've been using Perl::Metrics::Simple to automatically measure the complexity of a lot of my CPAN code using GitHub Actions (see workflow file here.

Today, I looked at one of the reports for App::MergeCal (see the "run countperl" job). I spotted that the code had a rather high complexity because it's all counted as "code not in named subroutines". I assume that's because I'm using the new perlclass feature and most of my code is in methods, not subroutines.

So this is just here to alert you to the issue. My plan is to look at your code and see if I can work out how to fix this and send you a pull request over the next couple of days.

[matisse]

Hi Dave and thanks for the report.

It is indeed true that Perl::Metrics::Simple relies on the sub keyword to find subroutines.
See Perl/Metrics/Simple/Analysis/File.pm line 141

It does this by with the [PPI](https://metacpan.org/pod/PPI::Statement::Sub)

I believe that currently there is not a PPI::Statement subclass for method

So, I am curious what solution you think might be helpful here?

[davorg]

Yeah, I think we need to start by adding a method class to PPI. I'll look into that.

[davorg]

See Perl-Critic/PPI#299

[matisse]

Noting for the record here the PPI
RFC: proof-of-concept for feature-tracking and perl sub signatures