Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emmet-core requirement for openbabel not declared #812

Open
drew-parsons opened this issue Aug 20, 2023 · 3 comments
Open

emmet-core requirement for openbabel not declared #812

drew-parsons opened this issue Aug 20, 2023 · 3 comments

Comments

@drew-parsons
Copy link

emmet-core uses openbabel (in emmet.core.qchem.molecule), but the dependency is not declared in setup.py. This makes packaging and installing more complex than it needs to be. Looks like openbabel should be added to the install_requires list in the setup.py for emmet-core.

@Andrew-S-Rosen
Copy link
Member

Andrew-S-Rosen commented Sep 4, 2023

@drew-parsons: Thanks for raising this issue. I agree that this would be very nice to add. Unfortunately, we are limited by the fact that pip is not working with the current version of openbabel (see openbabel/openbabel#2571). Until that issue is resolved or a new PyPI release is made, there's unfortunately not much that can be done in terms of the setup.py.

CC'ing @munrojm.

@tschaume
Copy link
Member

Adding openbabel-wheel as a dependency might be an option despite being an unofficial repo (see later comment in the issue that @Andrew-S-Rosen linked).

@drew-parsons
Copy link
Author

You can use an Ubuntu or Debian installation, with openbabel installed by the deb packages (python3-openbabel, libopenbabel-dev, openbabel). If your usual workstation uses a Microsoft Windows operating system instead of Linux, you can install a Linux (Ubuntu) environment via Microsoft's WSL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants