Skip to content

Latest commit

 

History

History
13 lines (12 loc) · 1.22 KB

File metadata and controls

13 lines (12 loc) · 1.22 KB
  • make sure you can't add movie with empty data (with spaces only);
  • don't interact with DOM directly, use React as much as possible;
  • make sure you described objects in propTypes;
  • don't use isLoad, it can be isLoading or isLoaded;
  • remove unused comments;
  • don't generate key on render (here is why)
  • follow these naming conventions for methods
  • check out what can go wrong if you pass initialize your state with props (here, here and here)
  • * don't use setState several times in one function call (method) (it's better for clarity of the code);
  • * use classnames library for defining classes conditionally;
  • * use try {..} catch for error handling

* - optional recommendation