Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for after_database_authentication callback #1580

Open
yasmin-ravenwolfe opened this issue Feb 23, 2023 · 2 comments
Open

Support for after_database_authentication callback #1580

yasmin-ravenwolfe opened this issue Feb 23, 2023 · 2 comments

Comments

@yasmin-ravenwolfe
Copy link

yasmin-ravenwolfe commented Feb 23, 2023 •
edited
Loading

Devise supports an after_database_authentication callback immediately after authenticating via the DatabaseAuthenticatable strategy (when calling authenticate!).

However DTA uses the controller method sign_in directly, which does not call this callback after successfully authenticating - similar to this issue's cause.

Would you be okay with me opening a PR to call this callback after sign_in in DeviseTokenAuth::Concerns::SetUserByToken? @lynndylanhurley Thanks!
@yshmarov
Copy link

I have the same issue. after_database_authentication is not getting triggered

@MaicolBen
Copy link
Collaborator

Would you be okay with me opening a PR to call this callback after sign_in in DeviseTokenAuth::Concerns::SetUserByToken? @lynndylanhurley Thanks!

Yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MaicolBen @yasmin-ravenwolfe @yshmarov