-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Ability to specify ConfigMap instead of startupScriptContent for init scripts #85
Comments
Didn't the init scripts at |
I believe so, yes. For localstack 2.0, the |
The problem is that the feature itself on the chart isn't enough to express the different classes of init scripts, nor does it actually place them into |
I do agree, that this would be quite complicated with the different stages. But on the other hand, most of the init scripts are for the Considering the specific feature itself - having the possibility to define a configmap instead of using the
This structure is considered an API (and not an implementation detail) for LocalStack, which means that this will not break between major releases. |
Being able to create the configmap ourselves would be ideal, as values files in helm can't accept templating and often the contents on that configmap are non-trivial. Being able to pass the chart the names of those configmaps for each kind of init script would be the cherry on the top, instead of following a naming convention. I'm a big believer on explicit, not implicit, configuration. But this is all mi opinion. |
Also I do not think it's unreasonable to make a BC break here on the chart, and bump major version. I don't think it's necessary to saddle ourselves with an ill-fitting api when semver is available. |
For this chart, there is no semantic versioning yet, because we are still in Do you see a nice way of getting the best of both worlds? How would the
I really want to stress (as above), that this is not a naming convention but part of the user-facing configuration API of LocalStack. LocalStack - in contrast to this chart - is being versioned according to semantic versioning. These changes will not break in between major releases (while technically this chart would be allowed to contain breaking changes in any version, even though we don't do it). |
There are some drawbacks to using the Value
startupScriptContent
as the initialization script. For example, if thelocalstack
helm chart is a subchart, renderingstartupScriptContent
doesn't have access to Values or Files from the parent chart. In this case, it's necessary to mount the initialization script manually, for example:It would be handy if we could mount a custom ConfigMap into localstack's
/etc/localstack/init/ready.d
directory. For example:would mount the given ConfigMap to the init script entry point.
The text was updated successfully, but these errors were encountered: