From 17f01cc482fcf5b2cfd1391aab97d570adca6ad7 Mon Sep 17 00:00:00 2001
From: Simon Walker <simon.walker@localstack.cloud>
Date: Thu, 12 Sep 2024 13:52:51 +0100
Subject: [PATCH] Move localstack test to an external file (#77)

PRs from forks do not run the LocalStack test since it requires a secret
that forks don't have access to.

This PR extracts the LocalStack test so that we can run it locally for
contributor PRs and assert that everything is ok.
---
 .github/execute-localstack-test.sh       | 37 ++++++++++++++++++++++++
 .github/workflows/test-appsync-utils.yml | 25 +++-------------
 2 files changed, 41 insertions(+), 21 deletions(-)
 create mode 100644 .github/execute-localstack-test.sh

diff --git a/.github/execute-localstack-test.sh b/.github/execute-localstack-test.sh
new file mode 100644
index 0000000..ad9b29e
--- /dev/null
+++ b/.github/execute-localstack-test.sh
@@ -0,0 +1,37 @@
+#!/usr/bin/env bash
+
+set -euo pipefail
+
+log() {
+    echo $@ >&2
+}
+
+(cd cdk
+
+set -x
+
+log "Installing dependencies"
+npm ci
+
+log "Bootstrapping"
+npm run cdklocal -- bootstrap
+
+log "Deploying"
+npm run cdklocal -- deploy --require-approval never --outputs-file outputs.json
+
+export TEST_URL=$(jq -r .CdkStack.GraphQLURL outputs.json)
+export TEST_API_KEY=$(jq -r .CdkStack.ApiKey outputs.json)
+
+log "Accessing URL ${TEST_URL} with api key ${TEST_API_KEY}"
+curl \
+    --connect-timeout 30 \
+    --retry 10 \
+    --retry-delay 6 \
+    -X POST \
+    -H "x-api-key:$TEST_API_KEY" \
+    -H "Accept:application/json" \
+    -H "Content-Type:application/json" \
+    $TEST_URL \
+    -d '{"query": "query { foo }"}'
+
+)
diff --git a/.github/workflows/test-appsync-utils.yml b/.github/workflows/test-appsync-utils.yml
index ce71ff3..c6bc9d8 100644
--- a/.github/workflows/test-appsync-utils.yml
+++ b/.github/workflows/test-appsync-utils.yml
@@ -1,4 +1,3 @@
-
 name: Test AppSync utils
 
 on:
@@ -49,8 +48,8 @@ jobs:
       - name: Start LocalStack
         uses: LocalStack/setup-localstack@v0.2.3
         with:
-          image-tag: 'latest'
-          use-pro: 'true'
+          image-tag: "latest"
+          use-pro: "true"
         env:
           LOCALSTACK_API_KEY: ${{ secrets.LOCALSTACK_API_KEY }}
           APPSYNC_JS_LIBS_VERSION: ${{ github.sha }}
@@ -59,24 +58,8 @@ jobs:
       - name: Ensure pro image is used
         run: curl -s http://localhost:4566/_localstack/health | grep appsync
       - uses: actions/setup-node@v4
-      - name: Install cdk project
-        working-directory: cdk
-        run: npm install
-      - name: CDK bootstrap
-        working-directory: cdk
-        run: npm run cdklocal -- bootstrap
-      - name: CDK deploy
-        working-directory: cdk
-        run: npm run cdklocal -- deploy --require-approval never --outputs-file outputs.json
-      - name: Fetch output variables for test step
-        working-directory: cdk
-        run: |
-          jq -r '"TEST_URL=\(.CdkStack.GraphQLURL)"' outputs.json >> $GITHUB_ENV
-          jq -r '"TEST_API_KEY=\(.CdkStack.ApiKey)"' outputs.json >> $GITHUB_ENV
-      - name: Invoke the URL
-        run: |
-          set -x
-          curl --connect-timeout 30 --retry 10 --retry-delay 6 -X POST -H "x-api-key:$TEST_API_KEY" -H "Accept:application/json" -H "Content-Type:application/json" $TEST_URL -d '{"query": "query { foo }"}'
+      - name: Execute test script
+        run: bash .github/execute-localstack-test.sh
       - name: Get the LocalStack logs
         if: success() || failure()
         run: |