Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing flag handling in ColorMyWorld #1603

Open
llaske opened this issue Apr 19, 2024 · 10 comments
Open

Missing flag handling in ColorMyWorld #1603

llaske opened this issue Apr 19, 2024 · 10 comments
Labels

Comments

@llaske
Copy link
Owner

llaske commented Apr 19, 2024

When there is a missing flag for a country in ColorMyWorld, the popup display undefined before the country name.
It will be better to display nothing in this case.

2t7nCztPC7

@vraj-712
Copy link

But i think you want to remove that undefined part, right ? not whole pop up box

@vraj-712
Copy link

vraj-712 commented May 2, 2024

Can you please describe how you want that?? because i am unable to understand your requirements

@llaske
Copy link
Owner Author

llaske commented May 4, 2024

Can you please describe how you want that?? because i am unable to understand your requirements

The fix suggested by @hharshas is good but is not enough. It solve the case where there is no existing emoji matching the country name in the activity.
But like I mentioned here, there is an existing emoji for St Vincent Grenadines. The problem is that the name mentioned in the flag constant doesn't match the name of the country so just changing the value to Saint_Vincent_and_the_Grenadines will make the flag appears.
So it should be nice to fix the value and double-check values for other countries.

@piyushmishraa
Copy link

hi i would like to work on this issue.Can you assign it to me

@hharshas
Copy link
Contributor

hharshas commented Jul 1, 2024

@piyushmishraa you can start working on it and also read the contribution guidelines first as it is mentioned there that there's no need to be assigned in an approved issue.

@piyushmishraa
Copy link

got it,thanks :)

@yashveeeeer
Copy link

@llaske i have made some changes could you review it and i also have some doubts.

@llaske
Copy link
Owner Author

llaske commented Aug 14, 2024

@yashveeeeer thanks for your contribution.

BTW your PR is not a the right place. It should be done on this repo. See https://github.com/llaske/sugarizer/blob/dev/CONTRIBUTING.md for more.

Plus, as I mentioned here it will be nice to check other missing flags.

@yashveeeeer
Copy link

Thanks alot @llaske I'll take care of the original repo and I'll check that problem you mentioned.

@llaske
Copy link
Owner Author

llaske commented Sep 18, 2024

Fixed in 461795e

@llaske llaske added the to be release Fixed, to be release label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants