Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lvm size optional #12

Open
tabowling opened this issue Nov 24, 2018 · 2 comments
Open

Make lvm size optional #12

tabowling opened this issue Nov 24, 2018 · 2 comments

Comments

@tabowling
Copy link
Contributor

Make lvm size option optional if only a single lvm is specified and assume 100% free space.
If multiple lvms are specified, space should be required.

@dwlehman
Copy link
Collaborator

I like this idea, but it will take some care to get it right -- especially over multiple playbook runs.

@pcahyna
Copy link
Member

pcahyna commented Nov 26, 2018

I have an idea to solve the percentage size, free space and idempotency dilemmas:
separate size and creationsize. The latter would apply only if a new volume is being created, for existing volumes it would be ignored. The default could be 100% free space. It could be expressed both as absolute numbers, percentages of free space or percentages of total space.
The former (size) would apply always. The default if not specified would be "do not change it". Only absolute units would be allowed. We could think about adding support for percentage of total space, but percentage of free space would be in any case forbidden.
I think that with this separation the role could be made idempotent with reasonable defaults for new volumes at the same time and keeping the specification reasonably simple as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants