Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About filepath (linux/win) #3397

Open
khan-lau opened this issue Nov 25, 2024 · 1 comment
Open

About filepath (linux/win) #3397

khan-lau opened this issue Nov 25, 2024 · 1 comment

Comments

@khan-lau
Copy link

Environment:

  • eKuiper version (e.g. 1.3.0): 1.14.x
  • Hardware configuration (e.g. lscpu): amd 16 core
  • OS (e.g. cat /etc/os-release): win11 mingw64
  • Others:

What happened and what you expected to happen:
源码中很多文件路径拼接的地方使用了path.join, 而非filepath.join, 从而导致移植到win平台时路径产生异常. 不过作者好像暂时也没有要移植到for win的意思, 我自己尝试简单的修改了相关部分. 是可以在windows下正常运行的.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:
linux版本使用的log库在配置文件滚动时, 如果文件滚动数量太小, 如果滚动文件名产生循环, 还会导致stream.log指向一个不存在的日志文件, 从而导致日志无法正确写入.

@ngjaying ngjaying changed the title 关于文件路径的的API使用有瑕疵(linux/win) About filepath (linux/win) Nov 26, 2024
@ngjaying
Copy link
Collaborator

Hi @khan-lau
Thanks for reporting the problem. If you already have fixes, we encourage you to open a PR so that we can merge to the codebase. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants