Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't bail when python lacks ssl support #6

Open
jbergstroem opened this issue Nov 22, 2011 · 2 comments
Open

Don't bail when python lacks ssl support #6

jbergstroem opened this issue Nov 22, 2011 · 2 comments

Comments

@jbergstroem
Copy link
Contributor

If your python is compiled without ssl support, simples3 will start to cry:

python2.5 setup.py build -b build-2.5
Traceback (most recent call last):
  File "setup.py", line 8, in <module>
    import simples3
  File "simples3/__init__.py", line 124, in <module>
    from .bucket import S3File, S3Bucket, S3Error, KeyNotFound
  File "simples3/bucket.py", line 66, in <module>
    class StreamHTTPSHandler(urllib2.HTTPSHandler):
AttributeError: 'module' object has no attribute 'HTTPSHandler'

IMO ssl should be optional and not required

@lericson
Copy link
Owner

It is optional, though it seems like a disservice to the end-user not to force the library user to think about it. I forget how exactly one sets plain HTTP up, but basically you change the service_url.

HTH
-L

@lericson
Copy link
Owner

As discussed on IRC it actually is required, mostly because the module-level names in simples3/bucket.py would need to be wrapped in ifs and things get ugly pretty quick. In fact I don't even know what StreamHTTPS?Handler is for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants