Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UDP audio support #38

Open
MarcusWolschon opened this issue Jun 6, 2017 · 4 comments
Open

UDP audio support #38

MarcusWolschon opened this issue Jun 6, 2017 · 4 comments

Comments

@MarcusWolschon
Copy link

https://github.com/layeh/gumble/blob/master/gumble/handlers.go#L79
The decoding, waiting for the lock and processing of the decoded audio buffer should probably be done asynchronously and not block the handling of further UDP packets.

@ghost
Copy link

ghost commented Jun 6, 2017

Ideally, gumble would implement UDP support, and the UDP connection would be running from a different go routine. I have a local branch that nearly implements UDP support. I can push that dev branch later today if you want to try tackling it, @MarcusWolschon.

@ghost ghost changed the title handleUDPTunnel doesn't sleep the thread while processing the buffer handleUDPTunnel blocks the thread while processing the buffer Jun 6, 2017
@MarcusWolschon
Copy link
Author

I've never coded in golang yet.

@dchote
Copy link

dchote commented Jun 16, 2017

I'd love to see UDP support

@ghost
Copy link

ghost commented Sep 15, 2017

I just pushed what I was playing around with to the udp branch

@ghost ghost changed the title handleUDPTunnel blocks the thread while processing the buffer UDP audio support Jun 5, 2020
@ghost ghost added the feature-request label Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants