Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUGGESTION] Remove need for config file #40

Open
emp-sean opened this issue Feb 10, 2021 · 1 comment
Open

[SUGGESTION] Remove need for config file #40

emp-sean opened this issue Feb 10, 2021 · 1 comment

Comments

@emp-sean
Copy link

Hiya, just a suggestion to remove an install step and keep things cleaner would be to remove the need for the config file and just use laravels services config file, placing the information in there (obviously still referencing the env file).

@acirinelli
Copy link

Hiya, just a suggestion to remove an install step and keep things cleaner would be to remove the need for the config file and just use laravels services config file, placing the information in there (obviously still referencing the env file).

This is a solid idea as long as there are no additional parameters to configure (right now there are not). Leaving it as is provides more flexibility for the future or custom configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants