Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SuccessHandler's function signature #23

Open
luckycatx opened this issue Jun 10, 2024 · 0 comments
Open

Change SuccessHandler's function signature #23

luckycatx opened this issue Jun 10, 2024 · 0 comments

Comments

@luckycatx
Copy link

Should change middleware jwt's SuccessHandler:

type JWTSuccessHandler func(c echo.Context)
-> type JWTSuccessHandler func(c echo.Context) error

It should be a minor change that will not affect most uses and API.
Reason: After obtaining the token, additional condition checks can be performed and the handler chain can be prevented from continuing to execute, instead of requiring an additional middleware.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant