From 90ba18705dd05825d019b0f7d8cf019f18011b72 Mon Sep 17 00:00:00 2001 From: Fabrizio Sestito Date: Fri, 26 Jul 2024 17:40:04 +0200 Subject: [PATCH 1/2] chore: bump tracing/metrics dev docker-compose otelc version to v0.103.0 Signed-off-by: Fabrizio Sestito --- hack/docker-compose.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hack/docker-compose.yml b/hack/docker-compose.yml index fae24085..7a8bf669 100644 --- a/hack/docker-compose.yml +++ b/hack/docker-compose.yml @@ -6,7 +6,7 @@ services: - "16686:16686" - "4318:4317" otel-collector: - image: otel/opentelemetry-collector:0.98.0 + image: otel/opentelemetry-collector:0.103.0 volumes: - ./otel-collector-minimal-config.yml:/etc/otel-collector-config.yml ports: From 1e7e344e51d3cfd1a992ee8870a9dce25572e134 Mon Sep 17 00:00:00 2001 From: Fabrizio Sestito Date: Fri, 26 Jul 2024 17:40:50 +0200 Subject: [PATCH 2/2] fix: call set_meter_provider to setup metrics Signed-off-by: Fabrizio Sestito --- src/metrics.rs | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/src/metrics.rs b/src/metrics.rs index 94c85f69..c3a3e9c8 100644 --- a/src/metrics.rs +++ b/src/metrics.rs @@ -1,6 +1,6 @@ -use opentelemetry::{metrics, KeyValue}; +use anyhow::Result; +use opentelemetry::{global, KeyValue}; use opentelemetry_otlp::{ExportConfig, WithExportConfig}; -use opentelemetry_sdk::metrics::SdkMeterProvider; use opentelemetry_sdk::runtime; mod policy_evaluations_total; @@ -10,15 +10,19 @@ pub use policy_evaluations_latency::record_policy_latency; const METER_NAME: &str = "kubewarden"; -pub fn setup_metrics() -> metrics::Result { - opentelemetry_otlp::new_pipeline() +pub fn setup_metrics() -> Result<()> { + let meter_provider = opentelemetry_otlp::new_pipeline() .metrics(runtime::Tokio) .with_exporter( opentelemetry_otlp::new_exporter() .tonic() .with_export_config(ExportConfig::default()), ) - .build() + .build()?; + + global::set_meter_provider(meter_provider.clone()); + + Ok(()) } pub trait PolicyEvaluationMetric: Into> {}