Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement for k8s.io/docs/concepts/storage/volume-snapshot-classes/ #49069

Open
vinzent opened this issue Dec 13, 2024 · 3 comments
Open

Improvement for k8s.io/docs/concepts/storage/volume-snapshot-classes/ #49069

vinzent opened this issue Dec 13, 2024 · 3 comments
Labels
language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/storage Categorizes an issue or PR as relevant to SIG Storage.

Comments

@vinzent
Copy link

vinzent commented Dec 13, 2024

The docs say:

Administrators can specify a default VolumeSnapshotClass for VolumeSnapshots that don't request any particular class to bind to by adding the snapshot.storage.kubernetes.io/is-default-class: "true" annotation:

It does not mention, that the default annotation can be set by CSI driver and not only once for all VolumeSnapshotClass resources.

Relevant comments from issues regarding this matter:

It takes the PVC's driver from PVC storage class, and try to find any VolumeSnapshot class with the default annotation AND has the same driver PVC driver. If there are multiple matches or no match, the snapshot will fail.

kubernetes/kubernetes#94312 (comment)

and:

Confirmed this behaves as expected. Created two VolumeSnapshotClasses with different CSI drivers, both marked as default. Created a VolumeSnapshot without providing a volumeSnapshotClassName, and it used the correct VolumeSnapshotClass based on the provisioner of the PVC.

kubernetes/kubernetes#94312 (comment)

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Dec 13, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

vinzent added a commit to vinzent/website that referenced this issue Dec 13, 2024
Each CSI driver can have a default VolumeSnapshotClass defined. 

Closes kubernetes#49069
@dipesh-rawat
Copy link
Member

Page reported in issue: https://kubernetes.io/docs/concepts/storage/volume-snapshot-classes
/language en

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Dec 13, 2024
@dipesh-rawat
Copy link
Member

/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/storage Categorizes an issue or PR as relevant to SIG Storage.
Projects
None yet
Development

No branches or pull requests

3 participants